ln-630-test-auditor

仓库: levnikolaevich/claude-code-skills
安装量: 116
排名: #7399

安装

npx skills add https://github.com/levnikolaevich/claude-code-skills --skill ln-630-test-auditor

Coordinates comprehensive test suite audit across 6 quality categories using 5 specialized workers.

Purpose & Scope

  • L2 Coordinator that delegates to L3 specialized audit workers

  • Audits all tests against 6 quality categories (via 5 workers)

  • Calculates Usefulness Score for each test (Keep/Remove/Refactor)

  • Identifies missing tests for critical business logic

  • Detects anti-patterns and isolation issues

  • Aggregates results into unified report

  • Creates single Linear task in Epic 0

  • Manual invocation by user; not part of Story pipeline

Core Philosophy

"Write tests. Not too many. Mostly integration." — Kent Beck "Test based on risk, not coverage." — ISO 29119

Key Principles:

  • Test business logic, not frameworks — bcrypt/Prisma/Express already tested

  • No performance/load/stress tests — Tests infrastructure, not code correctness (use k6/JMeter separately)

  • Risk-based prioritization — Priority ≥15 or remove

  • E2E for critical paths only — Money/Security/Data (Priority ≥20)

  • Usefulness over quantity — One useful test > 10 useless tests

  • Every test must justify existence — Impact × Probability ≥15

Workflow

Phase 1: Discovery (Automated)

Inputs: Codebase root directory

Actions:

  • Find all test files using Glob:

**/*.test.* (Jest, Vitest)

  • **/*.spec.* (Mocha, Jasmine)

  • **/__tests__/**/* (Jest convention)

  • Parse test file structure (test names, assertions count)

  • Auto-discover Team ID from docs/tasks/kanban_board.md

Output: testFilesMetadata — list of test files with basic stats

Phase 2: Research Best Practices (ONCE)

Goal: Gather testing best practices context ONCE, share with all workers

Actions:

Testing philosophy (E2E primary, Unit supplementary)

  • Usefulness Score formulas (Impact × Probability)

  • Anti-patterns catalog

  • Framework detection patterns

Output: contextStore — shared context for all workers

Key Benefit: Context gathered ONCE → passed to all workers → token-efficient

Phase 3: Domain Discovery (NEW)

Purpose: Detect project domains from production code folder structure for domain-aware coverage analysis.

Algorithm: (same as ln-360-codebase-auditor)

  • Priority 1: Explicit domain folders

Check for: src/domains/*/, src/features/*/, src/modules/*/

  • Monorepo patterns: packages/*/, libs/*/, apps/*/

  • If found (>1 match) → use as domains

  • Priority 2: Top-level src/ folders*

List folders: src/users/, src/orders/, src/payments/

  • Exclude infrastructure: utils, shared, common, lib, helpers, config, types, interfaces, constants, middleware, infrastructure, core

  • If remaining >1 → use as domains

  • Priority 3: Fallback to global mode

If <2 domains detected → domain_mode = "global"

  • All workers scan entire codebase (backward-compatible behavior)

Heuristics for domain detection:

| File count | >5 files in folder | src/users/ with 12 files

| Structure | controllers/, services/, models/ present | MVC/Clean Architecture

| Barrel export | index.ts/index.js exists | Module pattern

| README | README.md describes domain | Domain documentation

Output:

{
  "domain_mode": "domain-aware",
  "all_domains": [
    {"name": "users", "path": "src/users", "file_count": 45},
    {"name": "orders", "path": "src/orders", "file_count": 32},
    {"name": "shared", "path": "src/shared", "file_count": 15, "is_shared": true}
  ]
}

Shared folder handling:

  • Folders named shared, common, utils, lib, core → mark is_shared: true

  • Shared code audited but grouped separately in report

Phase 4: Delegate to Workers

Phase 4a: Global Workers (PARALLEL)

Global workers scan entire test suite (not domain-aware):

| 1 | ln-631-test-business-logic-auditor | Business Logic Focus | Framework/Library tests (Prisma, Express, bcrypt, JWT, axios, React hooks) → REMOVE

| 2 | ln-632-test-e2e-priority-auditor | E2E Priority | E2E baseline (2/endpoint), Pyramid validation, Missing E2E tests

| 3 | ln-633-test-value-auditor | Risk-Based Value | Usefulness Score = Impact × ProbabilityDecisions: ≥15 KEEP, 10-14 REVIEW, <10 REMOVE

| 5 | ln-635-test-isolation-auditor | Isolation + Anti-Patterns | Isolation (6 categories), Determinism, Anti-Patterns (6 types)

Invocation (4 workers in PARALLEL):

FOR EACH worker IN [ln-631, ln-632, ln-633, ln-635]:
  Skill(skill=worker, args=JSON.stringify(contextStore))

Phase 4b: Domain-Aware Worker (PARALLEL per domain)

Domain-aware worker runs once per domain:

| 4 | ln-634-test-coverage-auditor | Coverage Gaps | Missing tests for critical paths per domain (Money 20+, Security 20+, Data 15+, Core Flows 15+)

Invocation:

IF domain_mode == "domain-aware":
  FOR EACH domain IN all_domains:
    domain_context = {
      ...contextStore,
      domain_mode: "domain-aware",
      current_domain: { name: domain.name, path: domain.path }
    }
    Skill(skill="ln-634-test-coverage-auditor", args=JSON.stringify(domain_context))
ELSE:
  // Fallback: invoke once for entire codebase (global mode)
  Skill(skill="ln-634-test-coverage-auditor", args=JSON.stringify(contextStore))

Parallelism strategy:

  • Phase 4a: All 4 global workers run in PARALLEL

  • Phase 4b: All N domain-aware invocations run in PARALLEL

  • Example: 3 domains → 3 ln-374 invocations in single message

Each worker returns structured JSON:

{
  "category": "Business Logic Focus",
  "score": 7,
  "total_issues": 12,
  "findings": [
    {
      "severity": "MEDIUM",
      "test_file": "auth.test.ts",
      "test_name": "bcrypt hashes password",
      "decision": "REMOVE",
      "usefulness_score": 3,
      "reason": "Tests library behavior, not OUR code",
      "effort": "S"
    }
  ]
}

Phase 5: Aggregate Results

Goal: Merge all worker results into unified Test Suite Audit Report with domain grouping

Actions:

  • Collect results from all workers (global + domain-aware)

  • Global workers (ln-371, ln-372, ln-373, ln-375) → merge findings (as before)

  • Domain-aware worker (ln-374) → group by domain.name:

Aggregate coverage gaps per domain

  • Build Domain Coverage Summary table

  • Merge findings into decision categories:

Tests to REMOVE (Usefulness Score <10)

  • Tests to REVIEW (Usefulness Score 10-14)

  • Tests to KEEP (Usefulness Score ≥15)

  • Missing Tests (Priority/Justification) — grouped by domain if domain_mode="domain-aware"

  • Anti-Patterns Found (counts + examples)

  • Calculate compliance scores (6 categories, each /10)

  • Build decision summary (KEEP/REVIEW/REMOVE counts)

  • Generate Executive Summary (2-3 sentences)

  • Create Linear task in Epic 0 with full report (see Output Format below)

  • Return summary to user

Findings grouping:

  • Categories 1-3, 5-6 (Business Logic, E2E, Value, Isolation, Anti-Patterns) → single tables (global)

  • Category 4 (Coverage Gaps) → subtables per domain (if domain_mode="domain-aware")

Output Format

## Test Suite Audit Report - [DATE]

### Executive Summary
[2-3 sentences: test suite health, major issues, key recommendations]

### Test Count by Decision

| Decision | Count | % |
|----------|-------|---|
| KEEP | X | X% |
| REVIEW | X | X% |
| REMOVE | X | X% |
| **Total** | **X** | |

### Compliance Score

| Category | Score | Notes |
|----------|-------|-------|
| Business Logic Focus | X/10 | X framework tests found |
| E2E Priority | X/10 | X E2E, X Integration, X Unit |
| Risk-Based Value | X/10 | X tests with Priority <10 |
| Coverage Gaps | X/10 | X critical paths untested |
| Test Isolation | X/10 | X isolation issues |
| Anti-Patterns | X/10 | X anti-patterns found |
| **Overall** | **X/10** | |

### Domain Coverage Summary (NEW - if domain_mode="domain-aware")

| Domain | Critical Paths | Tested | Coverage % | Gaps |
|--------|---------------|--------|------------|------|
| users | 8 | 6 | 75% | 2 |
| orders | 12 | 8 | 67% | 4 |
| payments | 6 | 5 | 83% | 1 |
| **Total** | **26** | **19** | **73%** | **7** |

### Audit Findings

| Severity | Location | Issue | Violated Principle | Recommendation | Effort |
|----------|----------|-------|-------------------|----------------|--------|
| **CRITICAL** | - | Missing E2E for payment with discount | #3: E2E for critical paths only (Money Priority 25) | Add E2E test: successful payment + discount edge cases | M |
| **HIGH** | auth.test.ts:45 | Test "bcrypt hashes password" (Score 3) | #1: Test business logic, not frameworks | Delete — bcrypt already tested by maintainers | S |
| **HIGH** | db.test.ts:78 | Test "Prisma findMany returns array" (Score 4) | #1: Test business logic, not frameworks | Delete — Prisma ORM already tested | S |
| **HIGH** | - | Missing Unit test for tax calculation edge cases | #5: Every test must justify existence (Impact 5 × Probability 4 = 20) | Add Unit tests for country-specific tax rules | M |
| **MEDIUM** | utils.test.ts:23 | Test "validateEmail returns true" (Score 12) | #4: Usefulness over quantity | Review: if E2E login covers → DELETE; else KEEP | S |
| **MEDIUM** | order.test.ts:200-350 | Giant test (>100 lines) | Anti-pattern: The Giant | Split into focused tests (one scenario per test) | M |
| **MEDIUM** | test.ts:45 | No assertions in test | Anti-pattern: The Liar | Add specific assertions or delete test | S |
| **LOW** | auth.test.ts | Only positive login scenarios | Anti-pattern: Happy Path Only | Add negative tests (invalid credentials, expired tokens) | M |

### Coverage Gaps by Domain (if domain_mode="domain-aware")

#### Domain: users (src/users/)

| Severity | Category | Missing Test | Location | Priority | Effort |
|----------|----------|--------------|----------|----------|--------|
| CRITICAL | Money | E2E: processRefund() | services/user.ts:120 | 20 | M |
| HIGH | Security | Unit: validatePermissions() | middleware/auth.ts:45 | 18 | S |

#### Domain: orders (src/orders/)

| Severity | Category | Missing Test | Location | Priority | Effort |
|----------|----------|--------------|----------|----------|--------|
| CRITICAL | Money | E2E: applyDiscount() | services/order.ts:45 | 25 | M |
| HIGH | Data | Integration: orderTransaction() | repositories/order.ts:78 | 16 | M |

Worker Architecture

Each worker:

  • Receives contextStore with testing best practices

  • Receives testFilesMetadata with test file list

  • Loads full test file contents when analyzing

  • Returns structured JSON with category findings

  • Operates independently (failure in one doesn't block others)

Token Efficiency:

  • Coordinator: metadata only (~1000 tokens)

  • Workers: full test file contents when needed (~5000-10000 tokens each)

  • Context gathered ONCE, shared with all workers

Critical Rules

  • Two-stage delegation: Global workers (4) + Domain-aware worker (ln-374 × N domains)

  • Domain discovery: Auto-detect domains from folder structure; fallback to global mode if <2 domains

  • Parallel execution: All workers (global + domain-aware) run in PARALLEL

  • Domain-grouped output: Coverage Gaps findings grouped by domain (if domain_mode="domain-aware")

  • Delete > Archive: Remove useless tests, don't comment out

  • E2E baseline: Every endpoint needs 2 E2E (positive + negative)

  • Justify each test: If can't explain Priority ≥15, remove it

  • Trust frameworks: Don't test Express/Prisma/bcrypt behavior

  • No performance/load tests: Flag and REMOVE tests measuring throughput/latency/memory (DevOps Epic territory)

  • Code is truth: If test contradicts code behavior, update test

  • Language preservation: Report in project's language (EN/RU)

Definition of Done

  • All test files discovered via Glob

  • Context gathered from testing best practices (MCP Ref/Context7)

  • Domain discovery completed (domain_mode determined)

  • contextStore built with test metadata + domain info

  • Global workers (4) invoked in PARALLEL

  • Domain-aware worker (ln-374) invoked per domain in PARALLEL

  • All workers completed successfully (or reported errors)

  • Results aggregated with domain grouping (if domain_mode="domain-aware")

  • Domain Coverage Summary built (if domain_mode="domain-aware")

  • Compliance scores calculated (6 categories)

  • Keep/Remove/Refactor decisions for each test

  • Missing tests identified with Priority (grouped by domain if applicable)

  • Anti-patterns catalogued

  • Linear task created in Epic 0 with full report

  • Summary returned to user

  • Workers:

ln-631-test-business-logic-auditor — Framework tests detection

../ln-350-story-test-planner — Risk-Based Testing Guide

Version: 4.0.0 Last Updated: 2025-12-23

← 返回排行榜